Checkstyle Results

The following document contains the results of Checkstyle. rss feed

Summary

Files Infos Infos Warnings Warnings Errors Errors
12 0 0 79

Files

Files I Infos W Warnings E Errors
org/appfuse/webapp/controller/BaseFormController.java 0 0 24
org/appfuse/webapp/controller/FileUploadController.java 0 0 3
org/appfuse/webapp/controller/PasswordHintController.java 0 0 13
org/appfuse/webapp/controller/ReloadController.java 0 0 2
org/appfuse/webapp/controller/SignupController.java 0 0 4
org/appfuse/webapp/controller/UserController.java 0 0 2
org/appfuse/webapp/controller/UserFormController.java 0 0 6
org/appfuse/webapp/taglib/CountryTag.java 0 0 3
org/appfuse/webapp/taglib/LabelTag.java 0 0 16
org/appfuse/webapp/util/ValidationUtil.java 0 0 6

Rules

Rules Violations Severity
Translation 0 Errors Error
FileLength 0 Errors Error
FileTabCharacter
  • eachLine: "true"
 0 Errors Error
JavadocMethod
  • scope: "protected"
  • allowMissingPropertyJavadoc: "true"
  • allowThrowsTagsForSubclasses: "true"
  • allowUndeclaredRTE: "true"
 39 Errors Error
JavadocType
  • scope: "protected"
 0 Errors Error
JavadocVariable
  • scope: "protected"
 15 Errors Error
JavadocStyle
  • scope: "protected"
  • checkFirstSentence: "false"
 0 Errors Error
ConstantName
  • format: "^log$|^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"
 0 Errors Error
LocalFinalVariableName 1 Errors Error
LocalVariableName 0 Errors Error
MemberName 0 Errors Error
MethodName 0 Errors Error
PackageName 0 Errors Error
ParameterName 0 Errors Error
StaticVariableName 0 Errors Error
TypeName 0 Errors Error
AvoidStarImport 0 Errors Error
IllegalImport 0 Errors Error
RedundantImport 0 Errors Error
UnusedImports 2 Errors Error
LineLength
  • max: "120"
 1 Errors Error
MethodLength 0 Errors Error
ParameterNumber 0 Errors Error
EmptyForIteratorPad 0 Errors Error
MethodParamPad 0 Errors Error
NoWhitespaceAfter 3 Errors Error
NoWhitespaceBefore
  • allowLineBreaks: "true"
  • tokens: "DOT"
 0 Errors Error
OperatorWrap 2 Errors Error
ParenPad 0 Errors Error
TypecastParenPad 0 Errors Error
WhitespaceAfter 3 Errors Error
WhitespaceAround
  • tokens: "ASSIGN"
 0 Errors Error
ModifierOrder 2 Errors Error
RedundantModifier 0 Errors Error
AvoidNestedBlocks 0 Errors Error
EmptyBlock 0 Errors Error
LeftCurly 0 Errors Error
NeedBraces 0 Errors Error
RightCurly 0 Errors Error
DoubleCheckedLocking 0 Errors Error
EmptyStatement 0 Errors Error
EqualsHashCode 0 Errors Error
IllegalInstantiation 0 Errors Error
InnerAssignment 0 Errors Error
MissingSwitchDefault 0 Errors Error
RedundantThrows 0 Errors Error
SimplifyBooleanExpression 0 Errors Error
SimplifyBooleanReturn 0 Errors Error
FinalClass 0 Errors Error
HideUtilityClassConstructor 1 Errors Error
InterfaceIsType 0 Errors Error
VisibilityModifier
  • packageAllowed: "true"
  • protectedAllowed: "true"
 0 Errors Error
ArrayTypeStyle 0 Errors Error
FinalParameters
  • tokens: "CTOR_DEF"
 1 Errors Error
UpperEll 0 Errors Error
NestedIfDepth
  • max: "3"
 0 Errors Error
NestedTryDepth 0 Errors Error
ExplicitInitialization 12 Errors Error

Details

org/appfuse/webapp/controller/BaseFormController.java

Violation Message Line
Errors Missing a Javadoc comment. 43
Errors Missing a Javadoc comment. 44
Errors Variable 'userManager' explicitly initialized to 'null' (default value for its type). 45
Errors Missing a Javadoc comment. 46
Errors Variable 'mailEngine' explicitly initialized to 'null' (default value for its type). 46
Errors Missing a Javadoc comment. 47
Errors Variable 'message' explicitly initialized to 'null' (default value for its type). 47
Errors Missing a Javadoc comment. 48
Errors Missing a Javadoc comment. 49
Errors Missing a Javadoc comment. 50
Errors Missing a Javadoc comment. 72
Errors Missing a Javadoc comment. 82
Errors Expected an @return tag. 103
Errors Expected @param tag for 'msgKey'. 103
Errors Expected an @return tag. 116
Errors Expected @param tag for 'msgKey'. 116
Errors Expected @param tag for 'arg'. 116
Errors '{' is followed by whitespace. 117
Errors Expected an @return tag. 128
Errors Expected @param tag for 'msgKey'. 128
Errors Expected @param tag for 'args'. 128
Errors Missing a Javadoc comment. 209
Errors Missing a Javadoc comment. 214
Errors Missing a Javadoc comment. 226

org/appfuse/webapp/controller/FileUploadController.java

Violation Message Line
Errors Missing a Javadoc comment. 31
Errors Missing a Javadoc comment. 36
Errors Missing a Javadoc comment. 42

org/appfuse/webapp/controller/PasswordHintController.java

Violation Message Line
Errors Variable 'userManager' explicitly initialized to 'null' (default value for its type). 34
Errors Variable 'messageSource' explicitly initialized to 'null' (default value for its type). 35
Errors Missing a Javadoc comment. 36
Errors Variable 'mailEngine' explicitly initialized to 'null' (default value for its type). 36
Errors Missing a Javadoc comment. 37
Errors Variable 'message' explicitly initialized to 'null' (default value for its type). 37
Errors Missing a Javadoc comment. 59
Errors '+' should be on a new line. 85
Errors Line is longer than 120 characters. 91
Errors '{' is followed by whitespace. 91
Errors '{' is followed by whitespace. 94
Errors Missing a Javadoc comment. 103
Errors Missing a Javadoc comment. 114

org/appfuse/webapp/controller/ReloadController.java

Violation Message Line
Errors 'final' modifier out of order with the JLS suggestions. 31
Errors Missing a Javadoc comment. 33

org/appfuse/webapp/controller/SignupController.java

Violation Message Line
Errors Unused import - org.apache.commons.lang.StringUtils. 3
Errors Missing a Javadoc comment. 39
Errors Missing a Javadoc comment. 44
Errors Missing a Javadoc comment. 50

org/appfuse/webapp/controller/UserController.java

Violation Message Line
Errors Variable 'mgr' explicitly initialized to 'null' (default value for its type). 25
Errors Missing a Javadoc comment. 32

org/appfuse/webapp/controller/UserFormController.java

Violation Message Line
Errors Unused import - org.appfuse.service.UserManager. 9
Errors Missing a Javadoc comment. 47
Errors Missing a Javadoc comment. 52
Errors Missing a Javadoc comment. 153
Errors '+' should be on a new line. 161
Errors Missing a Javadoc comment. 211

org/appfuse/webapp/taglib/CountryTag.java

Violation Message Line
Errors Expected @param tag for 'scope'. 70
Errors Name 'EMPTY' must match pattern '^[a-z][a-zA-Z0-9]*$'. 156
Errors Parameter locale should be final. 191

org/appfuse/webapp/taglib/LabelTag.java

Violation Message Line
Errors Missing a Javadoc comment. 39
Errors Missing a Javadoc comment. 40
Errors 'final' modifier out of order with the JLS suggestions. 40
Errors Missing a Javadoc comment. 41
Errors Variable 'key' explicitly initialized to 'null' (default value for its type). 41
Errors Missing a Javadoc comment. 42
Errors Variable 'styleClass' explicitly initialized to 'null' (default value for its type). 42
Errors Missing a Javadoc comment. 43
Errors Variable 'errorClass' explicitly initialized to 'null' (default value for its type). 43
Errors Missing a Javadoc comment. 44
Errors Variable 'colon' explicitly initialized to 'false' (default value for its type). 44
Errors Missing a Javadoc comment. 46
Errors Expected @param tag for 'key'. 172
Errors Expected @param tag for 'colon'. 181
Errors Expected @param tag for 'styleClass'. 190
Errors Expected @param tag for 'errorClass'. 200

org/appfuse/webapp/util/ValidationUtil.java

Violation Message Line
Errors Utility classes should not have a public or default constructor. 21
Errors Expected an @return tag. 31
Errors Expected @param tag for 'bean'. 31
Errors Expected @param tag for 'va'. 31
Errors Expected @param tag for 'field'. 32
Errors Expected @param tag for 'errors'. 32