Checkstyle Results

The following document contains the results of Checkstyle. rss feed

Summary

Files Infos Infos Warnings Warnings Errors Errors
41 0 0 124

Files

Files I Infos W Warnings E Errors
org/appfuse/webapp/AppFuseEventConstants.java 0 0 1
org/appfuse/webapp/AppFuseSymbolConstants.java 0 0 5
org/appfuse/webapp/components/Header.java 0 0 2
org/appfuse/webapp/components/Layout.java 0 0 1
org/appfuse/webapp/components/MenuItem.java 0 0 1
org/appfuse/webapp/components/Meta.java 0 0 1
org/appfuse/webapp/components/UserForm.java 0 0 6
org/appfuse/webapp/data/FileData.java 0 0 1
org/appfuse/webapp/data/UserSession.java 0 0 2
org/appfuse/webapp/internal/MenuContext.java 0 0 1
org/appfuse/webapp/pages/AccessDenied.java 0 0 1
org/appfuse/webapp/pages/Error.java 0 0 1
org/appfuse/webapp/pages/FileUpload.java 0 0 1
org/appfuse/webapp/pages/Login.java 0 0 5
org/appfuse/webapp/pages/NotFound.java 0 0 1
org/appfuse/webapp/pages/UserEdit.java 0 0 5
org/appfuse/webapp/pages/admin/ActiveUsers.java 0 0 1
org/appfuse/webapp/pages/admin/UserList.java 0 0 1
org/appfuse/webapp/services/AppModule.java 0 0 14
org/appfuse/webapp/services/CountryService.java 0 0 1
org/appfuse/webapp/services/EmailService.java 0 0 1
org/appfuse/webapp/services/SecurityContext.java 0 0 10
org/appfuse/webapp/services/impl/BootstrapValidationDecorator.java 0 0 9
org/appfuse/webapp/services/impl/CountryServiceImpl.java 0 0 8
org/appfuse/webapp/services/impl/EmailServiceImpl.java 0 0 10
org/appfuse/webapp/services/impl/FileDataEncoder.java 0 0 2
org/appfuse/webapp/services/impl/RoleEncoder.java 0 0 5
org/appfuse/webapp/services/impl/SpringSecurityContext.java 0 0 9
org/appfuse/webapp/services/impl/UserEncoder.java 0 0 7
org/appfuse/webapp/services/impl/ValidationDelegate.java 0 0 10
org/appfuse/webapp/services/javascript/BootstrapJavaScriptStack.java 0 0 1

Rules

Rules Violations Severity
Translation 0 Errors Error
FileLength 0 Errors Error
FileTabCharacter
  • eachLine: "true"
 0 Errors Error
JavadocMethod
  • scope: "protected"
  • allowMissingPropertyJavadoc: "true"
  • allowThrowsTagsForSubclasses: "true"
  • allowUndeclaredRTE: "true"
 75 Errors Error
JavadocType
  • scope: "protected"
 4 Errors Error
JavadocVariable
  • scope: "protected"
 4 Errors Error
JavadocStyle
  • scope: "protected"
  • checkFirstSentence: "false"
 0 Errors Error
ConstantName
  • format: "^log$|^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"
 0 Errors Error
LocalFinalVariableName 1 Errors Error
LocalVariableName 0 Errors Error
MemberName 0 Errors Error
MethodName 0 Errors Error
PackageName 0 Errors Error
ParameterName 0 Errors Error
StaticVariableName 0 Errors Error
TypeName 0 Errors Error
AvoidStarImport 7 Errors Error
IllegalImport 0 Errors Error
RedundantImport 0 Errors Error
UnusedImports 5 Errors Error
LineLength
  • max: "120"
 0 Errors Error
MethodLength 0 Errors Error
ParameterNumber 0 Errors Error
EmptyForIteratorPad 0 Errors Error
MethodParamPad 1 Errors Error
NoWhitespaceAfter 0 Errors Error
NoWhitespaceBefore
  • allowLineBreaks: "true"
  • tokens: "DOT"
 0 Errors Error
OperatorWrap 1 Errors Error
ParenPad 0 Errors Error
TypecastParenPad 0 Errors Error
WhitespaceAfter 0 Errors Error
WhitespaceAround
  • tokens: "ASSIGN"
 0 Errors Error
ModifierOrder 4 Errors Error
RedundantModifier 0 Errors Error
AvoidNestedBlocks 0 Errors Error
EmptyBlock 0 Errors Error
LeftCurly 0 Errors Error
NeedBraces 0 Errors Error
RightCurly 1 Errors Error
DoubleCheckedLocking 0 Errors Error
EmptyStatement 0 Errors Error
EqualsHashCode 0 Errors Error
IllegalInstantiation 0 Errors Error
InnerAssignment 0 Errors Error
MissingSwitchDefault 0 Errors Error
RedundantThrows 2 Errors Error
SimplifyBooleanExpression 0 Errors Error
SimplifyBooleanReturn 0 Errors Error
FinalClass 0 Errors Error
HideUtilityClassConstructor 3 Errors Error
InterfaceIsType 0 Errors Error
VisibilityModifier
  • packageAllowed: "true"
  • protectedAllowed: "true"
 0 Errors Error
ArrayTypeStyle 0 Errors Error
FinalParameters
  • tokens: "CTOR_DEF"
 14 Errors Error
UpperEll 0 Errors Error
NestedIfDepth
  • max: "3"
 0 Errors Error
NestedTryDepth 0 Errors Error
ExplicitInitialization 2 Errors Error

Details

org/appfuse/webapp/AppFuseEventConstants.java

Violation Message Line
Errors Utility classes should not have a public or default constructor. 9

org/appfuse/webapp/AppFuseSymbolConstants.java

Violation Message Line
Errors Utility classes should not have a public or default constructor. 9
Errors Missing a Javadoc comment. 12
Errors Missing a Javadoc comment. 15
Errors Missing a Javadoc comment. 17
Errors Missing a Javadoc comment. 19

org/appfuse/webapp/components/Header.java

Violation Message Line
Errors Unused import - com.sun.org.apache.bcel.internal.generic.LoadClass. 3
Errors Unused import - org.apache.tapestry5.ioc.services.ThreadLocale. 5

org/appfuse/webapp/components/Layout.java

Violation Message Line
Errors Missing a Javadoc comment. 93

org/appfuse/webapp/components/MenuItem.java

Violation Message Line
Errors Missing a Javadoc comment. 81

org/appfuse/webapp/components/Meta.java

Violation Message Line
Errors Utility classes should not have a public or default constructor. 13

org/appfuse/webapp/components/UserForm.java

Violation Message Line
Errors Using the '.*' form of import should be avoided - org.apache.tapestry5.*. 3
Errors Using the '.*' form of import should be avoided - org.apache.tapestry5.annotations.*. 4
Errors Missing a Javadoc comment. 104
Errors Missing a Javadoc comment. 116
Errors Missing a Javadoc comment. 120
Errors Missing a Javadoc comment. 143

org/appfuse/webapp/data/FileData.java

Violation Message Line
Errors Missing a Javadoc comment. 65

org/appfuse/webapp/data/UserSession.java

Violation Message Line
Errors Missing a Javadoc comment. 9
Errors Missing a Javadoc comment. 42

org/appfuse/webapp/internal/MenuContext.java

Violation Message Line
Errors Missing a Javadoc comment. 10

org/appfuse/webapp/pages/AccessDenied.java

Violation Message Line
Errors Missing a Javadoc comment. 29

org/appfuse/webapp/pages/Error.java

Violation Message Line
Errors Missing a Javadoc comment. 19

org/appfuse/webapp/pages/FileUpload.java

Violation Message Line
Errors '+' should be on a new line. 93

org/appfuse/webapp/pages/Login.java

Violation Message Line
Errors Unused import - org.apache.tapestry5.Asset. 3
Errors Using the '.*' form of import should be avoided - org.apache.tapestry5.annotations.*. 5
Errors Unused import - org.apache.tapestry5.ioc.annotations.Value. 9
Errors Missing a Javadoc comment. 107
Errors Missing a Javadoc comment. 122

org/appfuse/webapp/pages/NotFound.java

Violation Message Line
Errors Missing a Javadoc comment. 29

org/appfuse/webapp/pages/UserEdit.java

Violation Message Line
Errors Using the '.*' form of import should be avoided - org.apache.tapestry5.annotations.*. 8
Errors Variable 'delete' explicitly initialized to 'false' (default value for its type). 105
Errors Variable 'cancel' explicitly initialized to 'false' (default value for its type). 108
Errors Missing a Javadoc comment. 115
Errors Missing a Javadoc comment. 120

org/appfuse/webapp/pages/admin/ActiveUsers.java

Violation Message Line
Errors Missing a Javadoc comment. 39

org/appfuse/webapp/pages/admin/UserList.java

Violation Message Line
Errors Missing a Javadoc comment. 57

org/appfuse/webapp/services/AppModule.java

Violation Message Line
Errors Using the '.*' form of import should be avoided - org.apache.tapestry5.services.*. 13
Errors Using the '.*' form of import should be avoided - org.appfuse.webapp.services.impl.*. 22
Errors Missing a Javadoc comment. 37
Errors Missing a Javadoc comment. 50
Errors Missing a Javadoc comment. 72
Errors Missing a Javadoc comment. 76
Errors Missing a Javadoc comment. 89
Errors Missing a Javadoc comment. 133
Errors Expected an @return tag. 165
Errors Expected @param tag for 'logger'. 166
Errors Expected @param tag for 'renderer'. 167
Errors Expected @param tag for 'componentSource'. 168
Errors Expected @param tag for 'productionMode'. 170
Errors Expected @param tag for 'service'. 171

org/appfuse/webapp/services/CountryService.java

Violation Message Line
Errors Missing a Javadoc comment. 11

org/appfuse/webapp/services/EmailService.java

Violation Message Line
Errors Missing a Javadoc comment. 12

org/appfuse/webapp/services/SecurityContext.java

Violation Message Line
Errors Missing a Javadoc comment. 7
Errors Expected an @return tag. 11
Errors Missing a Javadoc comment. 12
Errors Expected an @return tag. 18
Errors Missing a Javadoc comment. 20
Errors Expected an @return tag. 27
Errors Expected @param tag for 'roleName'. 27
Errors Expected an @return tag. 33
Errors Expected @param tag for 'user'. 39
Errors Expected an @return tag. 50

org/appfuse/webapp/services/impl/BootstrapValidationDecorator.java

Violation Message Line
Errors Missing a Javadoc comment. 22
Errors Parameter environment should be final. 22
Errors Parameter markupWriter should be final. 22
Errors Missing a Javadoc comment. 27
Errors Missing a Javadoc comment. 31
Errors Missing a Javadoc comment. 35
Errors Missing a Javadoc comment. 48
Errors Missing a Javadoc comment. 52
Errors Missing a Javadoc comment. 56

org/appfuse/webapp/services/impl/CountryServiceImpl.java

Violation Message Line
Errors Using the '.*' form of import should be avoided - java.util.*. 8
Errors Missing a Javadoc comment. 20
Errors Parameter logger should be final. 20
Errors Parameter threadLocale should be final. 20
Errors '(' should be on the previous line. 26
Errors Name 'EMPTY' must match pattern '^[a-z][a-zA-Z0-9]*$'. 37
Errors Parameter map should be final. 67
Errors Parameter locale should be final. 67

org/appfuse/webapp/services/impl/EmailServiceImpl.java

Violation Message Line
Errors 'private' modifier out of order with the JLS suggestions. 16
Errors 'private' modifier out of order with the JLS suggestions. 17
Errors 'private' modifier out of order with the JLS suggestions. 18
Errors Missing a Javadoc comment. 20
Errors Parameter simpleMailMessage should be final. 20
Errors Parameter mailEngine should be final. 20
Errors Parameter messages should be final. 20
Errors Missing a Javadoc comment. 27
Errors Redundant throws: 'UsernameNotFoundException' is unchecked exception. 28
Errors Redundant throws: 'MailException' is unchecked exception. 28

org/appfuse/webapp/services/impl/FileDataEncoder.java

Violation Message Line
Errors Missing a Javadoc comment. 14
Errors Missing a Javadoc comment. 18

org/appfuse/webapp/services/impl/RoleEncoder.java

Violation Message Line
Errors Missing a Javadoc comment. 8
Errors Missing a Javadoc comment. 12
Errors Parameter roleManager should be final. 12
Errors Missing a Javadoc comment. 16
Errors Missing a Javadoc comment. 20

org/appfuse/webapp/services/impl/SpringSecurityContext.java

Violation Message Line
Errors 'static' modifier out of order with the JLS suggestions. 25
Errors Missing a Javadoc comment. 27
Errors Missing a Javadoc comment. 39
Errors Missing a Javadoc comment. 52
Errors Missing a Javadoc comment. 63
Errors Missing a Javadoc comment. 68
Errors Missing a Javadoc comment. 92
Errors Missing a Javadoc comment. 96
Errors Missing a Javadoc comment. 103

org/appfuse/webapp/services/impl/UserEncoder.java

Violation Message Line
Errors Unused import - org.apache.tapestry5.ioc.internal.util.InternalUtils. 4
Errors Missing a Javadoc comment. 9
Errors Missing a Javadoc comment. 13
Errors Parameter userManager should be final. 13
Errors Missing a Javadoc comment. 17
Errors Missing a Javadoc comment. 21
Errors '}' should be on the same line. 30

org/appfuse/webapp/services/impl/ValidationDelegate.java

Violation Message Line
Errors Missing a Javadoc comment. 23
Errors Parameter environment should be final. 23
Errors Parameter iconAsset should be final. 23
Errors Parameter markupWriter should be final. 24
Errors Missing a Javadoc comment. 30
Errors Missing a Javadoc comment. 41
Errors Missing a Javadoc comment. 45
Errors Missing a Javadoc comment. 56
Errors Missing a Javadoc comment. 59
Errors Missing a Javadoc comment. 78

org/appfuse/webapp/services/javascript/BootstrapJavaScriptStack.java

Violation Message Line
Errors Missing a Javadoc comment. 28